Allow network admins to manage application passwords for all users#8638
Allow network admins to manage application passwords for all users#8638Sukhendu2002 wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
src/wp-includes/rest-api/endpoints/class-wp-rest-application-passwords-controller.php
Show resolved
Hide resolved
| * @ticket 60029 | ||
| * @group ms-required | ||
| */ | ||
| public function test_create_item_for_user_without_role_on_main_site() { |
There was a problem hiding this comment.
These tests are interesting but the only question that comes to my mind is that I can't see with these tests is that the actual method WP_REST_Application_Passwords_Controller::get_user that is causing the issue is not being asserted. So the test is failing because of an error, not because of a wrong assert.
SirLouen
left a comment
SirLouen
left a comment
There was a problem hiding this comment.
@Sukhendu2002 can you review the test?
|
@Sukhendu2002 are you available to update your PR according to @SirLouen proposal? |
3 participants
Trac ticket: https://core.trac.wordpress.org/ticket/60029
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.